Re: PSPP-BUG: pspp-0.10.2 buglet (+patch): missing function declarations when spreadsheet reading is not compiled in

[Friedrich Beckmann]

Hi,

thanks for reporting the problem and proposing a patch! I added this
in the bugtracker here:

http://savannah.gnu.org/bugs/?49550

Thanks!

Friedrich

> Am 06.11.2016 um 19:28 schrieb address@hidden:
> 
> First off many thanks for sharing this gem with the rest of the world!
> 
> 
> Problem: The pspp program fails to get linked when no spreadsheet
> reading support has been compiled in:
> 
>  $ grep _READ_SUPPORT config.h
>  /* #undef GNM_READ_SUPPORT */
>  /* #undef ODF_READ_SUPPORT */
> 
> The following error message are shown by the linker:
> 
>  src/.libs/libpspp-core.so: undefined reference to `ods_get_sheet_range'
>  src/.libs/libpspp-core.so: undefined reference to `gnumeric_get_sheet_range'
>  src/.libs/libpspp-core.so: undefined reference to `gnumeric_get_sheet_name'
>  src/.libs/libpspp-core.so: undefined reference to `ods_get_sheet_name'
>  collect2: ld returned 1 exit status
> 
> 
> 
> Solution: Apply the following patch which declares the missing functions,
> {ods,gnumeric}_get_sheet_{name,range}().
> 
> 
> diff --minimal --unidirectional-new-file --recursive -u 
> src/data.dist/gnumeric-reader.c src/data/gnumeric-reader.c
> --- src/data.dist/gnumeric-reader.c   2016-07-23 16:45:40 +0000
> +++ src/data/gnumeric-reader.c        2016-11-06 18:11:08 +0000
> @@ -50,6 +50,17 @@
> {
> }
> 
> +const char *
> +gnumeric_get_sheet_name (struct spreadsheet *s, int n)
> +{
> +  return NULL;
> +}
> +
> +char *
> +gnumeric_get_sheet_range (struct spreadsheet *s, int n)
> +{ 
> +  return NULL;
> +}
> 
> #else
> 
> diff --minimal --unidirectional-new-file --recursive -u 
> src/data.dist/ods-reader.c src/data/ods-reader.c
> --- src/data.dist/ods-reader.c        2016-07-23 16:45:40 +0000
> +++ src/data/ods-reader.c     2016-11-06 18:06:14 +0000
> @@ -56,6 +56,18 @@
> {
> }
> 
> +const char *
> +ods_get_sheet_name (struct spreadsheet *s, int n)
> +{
> +  return NULL;
> +}
> +
> +char *
> +ods_get_sheet_range (struct spreadsheet *s, int n)
> +{
> +  return NULL;
> +}
> +
> #else
> 
> #include "libpspp/zip-reader.h"