On Fri, Jun 15, 2012 at 05:46:05PM +0000, Gong, Henry wrote:
It took about 20 minutes for LIST to run, which is much faster than before, so it looks like the optimization fix works! Sometimes scrolling in psppire still freezes up, but other than that things seem to be working at a reasonable clip.
Wow! I'm glad we got that one solved. Thanks very much Henry and Harry, for your patience tracking this down.
I have pushed this change to master.
I build and released a new MSWindows version today.
Just out of interest, how many cases, and how many variables are in your test?
And more interest, how does it compare with the speed of the much version in situations where it didn't crash?
I'd be available for testing the temp file deletion; it seems that the temp files are sometimes not deleted when running psppire, but pspp is fine.
I noticed from some of your previous test results, the supports_delete_on_close function in
gl/clean-temp.c is returning false. Looking at the code, it seems that this code hasn't been updated
since Windows NT days, so perhaps this is relevant.
Harry, would you like to produce a test version with a hard coded "return true;" in the body
of the function supports_delete_on_close ? If Henry reports that this fixes the temp file deltion problem,
then we can look into what should really go there.
Thanks once again everyone.
You are welcome.
Have fun