Re: PSPP-BUG: Re: [bug #22237] Pressing the 'End' key adds ten missing values to data viewer

[John Darrington]

OK.  I checked this in for now.

It probably needs revisiting in the future, but to do it properly
will, I think, involve majorish changes to gtksheet and quite a lot of
other things too.   I want to do that sometime, but I'm reluctant to
do so at this stage.

Ben, can you check that this patch doesn't cause any problems with
your use of gtksheet in the text import thingy.

J'


On Fri, Feb 08, 2008 at 05:19:24PM -0500, Jason Stover wrote:
     On Sat, Feb 09, 2008 at 06:32:12AM +0900, John Darrington wrote:
     > On Fri, Feb 08, 2008 at 06:08:51PM +0000, Jason H Stover wrote:
     >      
     >      Follow-up Comment #2, bug #22237 (project pspp):
     >      
     >      Pressing the 'End' key no longer inserts missing
     >      cases in the data sheet, but does put the focus
     >      ten rows below the last case.
     > 
     > That's because that is where the end of the datasheet is.  What would
     > you expect to happen when you press End?
     > 
     > We can make it behave different, but bear in mind, that the last
     > row in the datasheet has to be at least one row beyond the last case,
     > otherwise it wouldn't be possible to insert new cases.  I think the
     > number 10 was chosen simply because it means that scrolling to the end
     > of the datasheet puts the last case somewhere in the middle of the
     > screen.
     
     It isn't a big deal, but the other software sends the focus to the last
     case in the data set, rather than ten cases past that. In fact, the other
     software will not allow the focus to extend beyond the last case in the 
data.
     
     Displaying ten rows beyond the last case looks good. I would not change 
that.
     
     My thought was that if it required only a simple fix, it would be worth 
the effort,
     but if it takes a lot of code, it's better to live with it for now.
     

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature