PSPP-BUG: [bug #18860] Need a quoting function and/or conversion .

[Ben Pfaff]

Update of bug #18860 (project pspp):

                  Status:   Ready for Test/Review => Works For Me           
             Assigned to:                     blp => jmd                    

    _______________________________________________________

Follow-up Comment #3:

Could the function named "quote" be renamed?  It conflicts with the "quote"
function in gnulib, which although we don't use now we will probably want to
use in the future.

The following:

  /* Copy the quoted string into str */
  ds_destroy (str);
  ds_init_string (str, &quoted_str);
  ds_destroy (&quoted_str);

can be simplified into:

  ds_swap (str, &quoted_str);
  ds_destroy (&quoted_str);

and it'll avoid copying data to boot.

What reason do you foresee for wanting to escape '%'s?  To me this option
just looks like a bad idea.  It seems to encourage the idea of passing user
data as part of the format string to printf and friends, and I can't say I
like to encourage that.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?18860>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/