[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gnu-libiconv] Changed genaliases.c to create canonical.sh as a
|
From: |
Bruno Haible |
|
Subject: |
Re: [bug-gnu-libiconv] Changed genaliases.c to create canonical.sh as a binary file |
|
Date: |
Sun, 26 Nov 2017 20:30:35 +0100 |
|
User-agent: |
KMail/5.1.3 (Linux/4.4.0-98-generic; KDE/5.18.0; x86_64; ; ) |
Hi,
> if compiled with cygwin gcc, fprintf() to a text file (opened with "w", not
> "wb") a '\n' will write 0D 0A instead of 0A.
It did not happen for me, but Cygwin's text mode / binary mode behaviour [1]
is not very predictible. Therefore it makes sense to protect against this
problem.
> See the attached patch file.
Thanks. Applied. [2]
Bruno
[1] https://cygwin.com/cygwin-ug-net/using-textbinary.html
[2]
http://git.savannah.gnu.org/gitweb/?p=libiconv.git;a=commitdiff;h=555ccdd7f6479cfbb5ef7c74f64316611c357058