Re: [bug-gnu-libiconv] several avoidable compiler warnings when compiling libiconv

[Bruno Haible]

Hi,

Uwe Stöhr wrote:
> I updated now to libiconv 1.15 and get even more warnings to be fixed:

Thanks for the report. These warnings need to be analyzed, not fixed.

Warnings about signed/unsigned mismatch can be ignored, because they
are usually pointless (don't point to a dangerous situation).

In general, it is good to listen to "gcc -Wall" warnings. When you use
other compilers, be prepared to see many useless warnings.

> 2>d:\lyxgit\master\3rdparty\libiconv\1.15\lib\loop_wchar.h(39): warning 
> C4273: 'mbrtowc': inconsistent dll linkage
> 2>  C:\Program Files (x86)\Windows 
> Kits\10\Include\10.0.10240.0\ucrt\wchar.h(65): note: see previous 
> definition of 'mbrtowc'

Ignore. MSVC does the right thing for function declarations even without
DLL linkage declaration. This warning is only relevant for variables.

> 2>D:\LyXGit\Master\3rdparty\libiconv\1.15\lib\iconv.c(431): warning 
> C4090: 'function': different 'const' qualifiers

I don't see the reason for this warning: compare_by_name takes 2 'const void *'
arguments, like the function expects [1]. Ignore.

I could understand if there was a warning about a missing __cdecl specifier
when compiling for x86. But that's not what the warning says. And that's not
an issue when compiling for x86_64 [2].

Bruno

[1] https://msdn.microsoft.com/en-us/library/zes7xw0h.aspx
[2] 
https://en.wikipedia.org/wiki/X86_calling_conventions#x86-64_calling_conventions