[bug-gnu-libiconv] libiconv-1.13.1 fails to build on hppa*-hpux due to mbstate_t

[Peter O'Gorman]

Hi,

        /bin/sh ../libtool --mode=compile cc -I. -I. -I../include
-I./../include -I.. -I./..  -g  -DLIBDIR=\"/usr/local/lib\"
-DBUILDING_LIBICONV -DBUILDING_DLL  -DENABLE_RELOCATABLE=1 -DIN_LIBRARY
-DINSTALLDIR=\"/usr/local/lib\" -DNO_XMALLOC
-Dset_relocation_prefix=libiconv_set_relocation_prefix
-Drelocate=libiconv_relocate -DHAVE_CONFIG_H -c ./iconv.c
libtool: compile:  cc -I. -I. -I../include -I./../include -I.. -I./.. -g
-DLIBDIR=\"/usr/local/lib\" -DBUILDING_LIBICONV -DBUILDING_DLL
-DENABLE_RELOCATABLE=1 -DIN_LIBRARY -DINSTALLDIR=\"/usr/local/lib\"
-DNO_XMALLOC -Dset_relocation_prefix=libiconv_set_relocation_prefix
-Drelocate=libiconv_relocate -DHAVE_CONFIG_H -c ./iconv.c  +Z -DPIC -o
.libs/iconv.o
cc: "../include/iconv.h", line 120: error 1000: Unexpected symbol:
"mbstate_t".
cc: "../include/iconv.h", line 120: error 1573: Type of "dummy2" is
undefined due to an illegal declaration.

This is, of course, because _XOPEN_SOURCE is not defined to 500, so
_INCLUDE__STDC_A1_SOURCE doesn't get defined, so no mbstate_t type.

While this is easy enough to solve for building libiconv itself (just
put
#ifndef _XOPEN_SOURCE
#undef _XOPEN_SOURCE
#endif
at the end of lib/config.h.in, iconv.h is a public header, so every
client of libiconv would have to ensure that _XOPEN_SOURCE is defined to
500 before including iconv.h, which could be problematic.

Putting the #define in iconv.h.in itself could also cause issues with
clients having to ensure that wchar.h does not get #included before
iconv.h.

Is there a better solution? 

Thanks,
Peter
-- 
Peter O'Gorman
address@hidden