Re: [bug-gnu-libiconv] libiconv-1.13 on Interix 3.5 with fixes

[Bruno Haible]

Hi,

Jay Krell wrote:
> libiconv-1.13 on Interix 3.5:
> In file included from /src/libiconv-1.13/lib/iconv.c:234:
> 
> /src/libiconv-1.13/lib/iconv_open2.h: In function `libiconv_open':
> 
> /src/libiconv-1.13/lib/iconv_open2.h:85: error: structure has no member named 
> `state'
> 
> /src/libiconv-1.13/lib/iconv_open2.h:85: error: `mbstate_t' undeclared (first 
> use in this function)

Thanks for reporting this. It has been fixed in the libiconv CVS two weeks ago:
  
http://cvs.savannah.gnu.org/viewvc/libiconv/lib/iconv_open2.h?root=libiconv&r1=1.1&r2=1.2

> or maybe simpler to just:
> 
> < cd = (struct conv_struct *) malloc(from_wchar != to_wchar
> 
> > cd = (struct conv_struct *) calloc(1, from_wchar != to_wchar
> 
> and then remove all the explicit field by field zeroing?

Thanks for the suggestion. It would indeed be simpler, but more fragile. (When a
field is introduced whose default value is not 0, ...)

Bruno

PS: Your mail was a HTML mail. Such mails do not appear well on public mailing 
lists.
    In particular, it caused a blank line to appear between every two lines.