[bug-gnu-libiconv] Re: pkgsrc patches for libiconv-1.11

[Bruno Haible]

Hello,

Thomas Klausner wrote:
> I updated the NetBSD pkgsrc package for libiconv to 1.11.
> There were 5 patches that still apply to 1.11, I'll attach them to
> this mail.
> 
> I'll try to explain them below:

Thanks for explaining.

> patch-aa: commit message was:
> revision 1.6
> date: 2003/09/16 13:57:19;  author: xtraeme;  state: Exp;  lines: +12 -22
> Don't try to link to -liconv in the install process, it fixes build in
> FreeBSD. Closes my own PR pkg/22346.

> $(LIBTOOL_LINK) $(CC) $(LDFLAGS) ... ../lib/libiconv.la ...

It is my understanding that when you link with an uninstalled libtool
library, on many platforms, a wrapper script is created in place of a
real executable. This wrapper script sets LD_LIBRARY_PATH and then execs
the .libs/lt-iconv. It would be wrong to install this script in a public
location.

> You can find the PR at
>       http://www.NetBSD.org/cgi-bin/query-pr-single.pl?number=22346

Doesn't apply to libiconv-1.9.2 and newer.

> patch-ab:
> revision 1.8
> date: 2004/04/02 19:08:37;  author: jschauma;  state: Exp;  lines: +3 -3
> Apparently cp(1) under Irix does not like to overwrite symbolic links.
> This causes the package to fail to install, as this section is executed
> a second time.
> Use pax instead and all's peachy.

pax is not portable yet (although it's mandated by POSIX).

This Makefile rule should only be executed once, since it creates
lib/localcharset.h.

Furthermore, the only symlinks are in the .libs directory, and 'libtool',
not 'cp', is used to copy the libraries from .libs. So if there's a problem
there, please report a bug in GNU libtool.

> patch-ac:
> Looks like it creates too many dirs.

These mkinstalldirs invocations were just redundant. I remove them. Likewise
in three other Makefile.ins.

> patch-ae:
> revision 1.4
> date: 2004/04/28 15:19:04;  author: tv;  state: Exp;  lines: +7 -5
> nb2: use $(INSTALL), not $(INSTALL_DATA), for a library in an autoconfiscated
> package.

On most platforms, a library does not need a+x permissions. On those where
it does (such as HP-UX), libtool takes care of it.

> revision 1.5
> date: 2006/11/14 13:55:34;  author: joerg;  state: Exp;  lines: +17 -8
> DESTDIR support. Use modular Xorg for wv.

'install-lib' is not a public target. Only other Makefiles in libiconv use it,
and never with DESTDIR. So the patch is pointless.

> patch-af:
> revision 1.1
> date: 2004/04/28 15:19:04;  author: tv;  state: Exp;
> nb2: use $(INSTALL), not $(INSTALL_DATA), for a library in an autoconfiscated
> package.

See above.

Thanks for taking care to synchronize "downstream" and "upstream" versions of
a package.

Bruno