[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#74361: [PATCH] New option xref-navigation-display-window-action
From: |
Eli Zaretskii |
Subject: |
bug#74361: [PATCH] New option xref-navigation-display-window-action |
Date: |
Mon, 18 Nov 2024 19:03:08 +0200 |
> Date: Mon, 18 Nov 2024 18:10:02 +0200
> Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> >> xref-query-replace-in-results will not (or its twin
> >> xref-find-references-and-replace). I suppose not many people would
> >> expect them to.
> >
> > This seems to indicate that my proposal is actually okay, since the
> > above two commands do not "show results of Xref commands"?
>
> IIUC your suggestion was:
>
> If non-nil, the `display-buffer' action for showing results of Xref
> commands.
>
> And those are commands belonging to the package (for the moment), and as
> such fitting the description.
Not in my book (they are replacement commands), but feel free to find
better text.
> >> Also, there is a nuance: when the Xref buffer itself is shown (i.e. when
> >> there are multiple locations matching a xref-find-definitions search),
> >> we're not going to pass (category . xref) to display-buffer either - it
> >> is reserved for displaying the buffers of destination locations.
> >
> > And this is a separate issue, not related to the doc string?
>
> Still about the doc string.
But not important enough to affect the first line of it.
> If we say "showing results of Xref
> commands", then the Xref buffer with the list of locations also matches
> that description, doesn't it? Or rather it might be the first thing a
> user would think of - but our customization wouldn't apply to it
> immediately.
The rest of the doc string could explain this subtlety.
- bug#74361: [PATCH] New option xref-navigation-display-window-action, (continued)
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Eli Zaretskii, 2024/11/15
- bug#74361: [PATCH] New option xref-navigation-display-window-action, martin rudalics, 2024/11/15
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Dmitry Gutov, 2024/11/15
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Eli Zaretskii, 2024/11/16
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Dmitry Gutov, 2024/11/17
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Eli Zaretskii, 2024/11/18
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Dmitry Gutov, 2024/11/18
- bug#74361: [PATCH] New option xref-navigation-display-window-action,
Eli Zaretskii <=
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Dmitry Gutov, 2024/11/18
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Eli Zaretskii, 2024/11/19
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Dmitry Gutov, 2024/11/19
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Eli Zaretskii, 2024/11/20
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Eli Zaretskii, 2024/11/21
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Juri Linkov, 2024/11/21
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Eli Zaretskii, 2024/11/21
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Juri Linkov, 2024/11/21
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Eli Zaretskii, 2024/11/21
- bug#74361: [PATCH] New option xref-navigation-display-window-action, Juri Linkov, 2024/11/22