bug#73005: [REGRESSION, BISECTED]: line numbers disappear when pressing `df` in evil-mode

[David Ponce]

On 04/11/2024 8:53 PM, Konstantin Kharlamov wrote:
> On Mon, 2024-11-04 at 22:50 +0300, Konstantin Kharlamov wrote:
> > A more curious way to get line numbers is evaluating just `display-
> > line-numbers`, i.e. without any modification.
>
> s/to get line numbers/to get line numbers back
>
> Sorry, I was re-editing this sentence and screwed it up 😅

It seems the problem is the non-nil argument passed to
`kill-all-local-variables' to also kill permanent local variables:

Here is a minimal recipe:

emacs -Q --eval "(setq-default display-line-numbers 'visual)"

Then evaluate in the *scratch* buffer:

(with-temp-buffer
  (setq-local display-line-numbers nil)
  (kill-all-local-variables t))

==> Line numbers disappear.

emacs -Q --eval "(setq-default display-line-numbers 'visual)"

Then evaluate in the *scratch* buffer:

(with-temp-buffer
  (setq-local display-line-numbers nil)
  (kill-all-local-variables))

==> Line numbers don't change.

No idea why.