bug#70725: 29.3; dired-do-touch completion

[Thierry Volpiatto]

Juri Linkov <juri@linkov.net> writes:

>>>> > However this doesn't explain why dired-do-touch uses a completing-read
>>>> 
>>>> Indeed, this was an oversight.  Here is the patch
>>>> that replaces 'completing-read' with 'read-string':
>>>
>>> Thierry, is this solution okay with you?
>>
>> This fix one issue,
>
> Thanks, so I pushed the fix.

Thanks.

>> but default is still wrong IMHO:
>>
>> When pressing RET with an empty prompt the value is different than what
>> is inserted in minibuffer with M-n.  Why do we bother setting the
>> timesamp at the exact time when pressing RET instead of when pressing
>> "T", I mean user would consider the timestamp is set once "T" is
>> pressed, with this the behavior would be consistent with RET and M-n and
>> the code much simpler.
>
> There is no need to make the value used by RET and the value inserted by M-n
> consistent in 100% of cases.

Sorry but I disagree on this.

-- 
Thierry

signature.asc
Description: PGP signature