[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#70894: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width ca
From: |
martin rudalics |
Subject: |
bug#70894: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width calculation |
Date: |
Sun, 19 May 2024 09:58:58 +0200 |
User-agent: |
Mozilla Thunderbird |
> Martin, any comments?
Looks good to me. Principally, instead of subtracting the sizes of the
decorations from the initial total width and re-adding them later, they
should have been added to the calculated pixel width as is done when
fitting the height.
But mildly spoken, 'fit-window-to-buffer' is a complete mess in the
first place. Calculating sizes in terms of lines/columns doesn't make
sense. If really necessary - minibuffer resizing, for example, does not
care - results should be rounded in a final step. Also, I doubt that
both char-width and char-height are calculated reasonably when buffer
text is scaled or line spacing changed.
martin