[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color
From: |
Eli Zaretskii |
Subject: |
bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’ |
Date: |
Fri, 30 Jun 2023 09:00:33 +0300 |
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: 64232@debbugs.gnu.org, eliz@gnu.org, zack@owlfolio.org
> Date: Fri, 30 Jun 2023 06:02:36 +0200
>
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
> > Someone™ should sit down and figure out how to make `bytecomp.el` keep
> > track of those things more reliably/predictably.
> > In the mean time, maybe we can simply tweak `byte-compile-eval` so it
> > never adds to `byte-compile-noruntime-functions` functions which have
> > already been seen/declared during the current compilation?
> >
> >
> > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
> > index 99202185d8d..cfec4b3be06 100644
> > --- a/lisp/emacs-lisp/bytecomp.el
> > +++ b/lisp/emacs-lisp/bytecomp.el
> > @@ -1128,7 +1128,8 @@ byte-compile-eval
> > ;; we arguably should add it to b-c-noruntime-functions,
> > ;; but it's not clear it's worth the trouble
> > ;; trying to recognize that case.
> > - (unless (get f 'function-history)
> > + (unless (or (get f 'function-history)
> > + (assq f
> > byte-compile-function-environment))
> > (push f
> > byte-compile-noruntime-functions)))))))))))))
>
> Seems appropriate (and fixes this bug).
>
> Actually with that patch the situation looks already quite ok'ish to me.
Please install this on master, and thanks.
- bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’, Zack Weinberg, 2023/06/22
- bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’, Eli Zaretskii, 2023/06/24
- bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’, Zack Weinberg, 2023/06/24
- bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’, Michael Heerdegen, 2023/06/27
- bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’, Stefan Monnier, 2023/06/28
- bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’, Michael Heerdegen, 2023/06/28
- bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’, Stefan Monnier, 2023/06/29
- bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’, Michael Heerdegen, 2023/06/30
- bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’,
Eli Zaretskii <=
bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’, Michael Heerdegen, 2023/06/29