[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): On
From: |
Morgan Smith |
Subject: |
bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. |
Date: |
Tue, 06 Jun 2023 15:08:26 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
I'm running on commit 7ca1d782f5910d0c3978c6798a45c6854ec668c7 from the
master branch.
I really hoping you can reproduce it with this:
0001-Add-test-for-when-completion-auto-help-is-visible.patch
Description: Text Data
It should error out because apparently dings cause ert errors. I did
not know that before but I am happy about it.
Eli Zaretskii <eliz@gnu.org> writes:
>
>> Also that situation doesn't respect completion-fail-discreetly if you
>> where to type in a failing completion before the final TAB press.
>
> Recipe, please.
I said this from a static analysis point of view but I couldn't seem to
reproduce this with a test. It might be a dead code pathway but it
would still be nice for it to be correct.
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate., Morgan Smith, 2023/06/05
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate., Eli Zaretskii, 2023/06/05
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate., Morgan Smith, 2023/06/05
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate., Eli Zaretskii, 2023/06/06
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate.,
Morgan Smith <=
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate., Eli Zaretskii, 2023/06/08
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate., Stefan Monnier, 2023/06/08
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate., Eli Zaretskii, 2023/06/10
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate., Morgan Smith, 2023/06/10
- bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate., Eli Zaretskii, 2023/06/10