bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#62234: Toolbar does not work properly (with Emacs 29 or 30)


From: Konrad Podczeck
Subject: bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
Date: Thu, 23 Mar 2023 15:57:35 +0100

Thanks!

Konrad

Am 23.03.2023 um 09:10 schrieb Eli Zaretskii <eliz@gnu.org>:

From: Daniel Martín <mardani29@yahoo.es>
Cc: Eli Zaretskii <eliz@gnu.org>,  62234@debbugs.gnu.org,  Konrad Podczeck
<konrad.podczeck@univie.ac.at>
Date: Sat, 18 Mar 2023 11:25:51 +0100

Po Lu <luangruo@yahoo.com> writes:

+-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
+{
+    return [toolbarItem isEnabled];
+}
+

This does no harm on GNUstep.  However, please indent with two spaces,
and place spaces after -, :, and ):

- (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
{
 return [toolbarItem isEnabled];
}

Otherwise, LGTM.  Thanks.

OK, I've attached a new version of the patch.  Konrad, could you check
if with this patch the Emacs toolbar works as you expect?  Thanks.

Thanks, installed on the emacs-29 branch, and closing the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]