[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59684: 29.0.50; [PATCH] package.el: Insert news for installed packag
From: |
Philip Kaludercic |
Subject: |
bug#59684: 29.0.50; [PATCH] package.el: Insert news for installed packages only |
Date: |
Wed, 30 Nov 2022 19:53:54 +0000 |
Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>>>>> + ((file-regular-p file)))
>>>>
>>>> Shouldn't we keep `file-readable-p'?
>>>
>>> I think we should use `file-regular-p' so even if the pkg-dir will
>>> contain directory named "news" we will not try to insert it with
>>> `insert-file-contents'.
>>
>> I agree that `file-regular-p' is sensible, what I meant was using
>> `file-readable-p' in addition to that. But I guess that all in all,
>> this is a rare circumstance...
>
> Oh, right. Makes sense. I've updated the patch.
Thanks, I've pushed the change.