[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress
From: |
Danny Freeman |
Subject: |
bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot |
Date: |
Fri, 25 Nov 2022 11:15:33 -0500 |
Stephen Leake <stephen_leake@stephe-leake.org> writes:
> João Távora <joaotavora@gmail.com> writes:
>
>> 1. Get rid of the :apply-edit progress reporter entirely. To be honest,
>> I don't think it's doing much. We could just as well have a call to
>> message there, or nothing at all.
>> 2. Do my original "sketchy" suggestion, where :$progress is considered a
>> built-in ignorable capability (and checked with eglot--server-capable
>> in the new code that Danny is proposing). Stephen's eglot-connect
>> trick is an acceptable technique.
>>
>> 3. Add a boolean user varible eglot-report-progress. I don't like to
>> add user variables unless they represent things directly related to
>> the fundamental LSP logic, and not its customization or evolution.
>> Since this seems to be of those fundamental things, I think it's
>> acceptable.
>>
>> The alternatives are:
>>
>> a: 1+2
>> b: 1+3
>> c: 2
>> d: 3
>>
>> Stephen, you request to shoosh that particular apply-edits progress
>> reporter is another separate request, we shouldn't let it block Danny's
>> effort to support $progress messages.
>> So I think we should do either 'c' or 'd' for now, and we can always
>> address your request later.
>
> Ok. Since that rules out b, I vote for d.
I am more partial to option d as well. From a user's perspective it
seems more straight forward than having to figure out the pseudo server
capability. I've attached an updated patch
--
Danny Freeman
0001-Eglot-Display-progress-notifications-in-minibuffer-a.patch
Description: eglot progress report patch
- bug#59149: Feature Request: Report progress of long requests in Eglot, (continued)
- bug#59149: Feature Request: Report progress of long requests in Eglot, Danny Freeman, 2022/11/19
- bug#59149: Feature Request: Report progress of long requests in Eglot, Stephen Leake, 2022/11/21
- bug#59149: Feature Request: Report progress of long requests in Eglot, Danny Freeman, 2022/11/23
- bug#59149: Feature Request: Report progress of long requests in Eglot, Stephen Leake, 2022/11/23
- bug#59149: Feature Request: Report progress of long requests in Eglot, Danny Freeman, 2022/11/23
- bug#59149: Feature Request: Report progress of long requests in Eglot, João Távora, 2022/11/23
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, Stephen Leake, 2022/11/24
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, João Távora, 2022/11/24
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, Stephen Leake, 2022/11/24
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, João Távora, 2022/11/25
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot,
Danny Freeman <=
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, Eli Zaretskii, 2022/11/25
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, Danny Freeman, 2022/11/25
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, Danny Freeman, 2022/11/25
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, João Távora, 2022/11/25
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, Danny Freeman, 2022/11/26
- bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot, Stefan Kangas, 2022/11/26
- bug#59149: Feature Request: Report progress of long requests in Eglot, Stephen Leake, 2022/11/22