bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursio


From: Mattias Engdegård
Subject: bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit
Date: Thu, 24 Nov 2022 11:24:19 +0100

24 nov. 2022 kl. 10.17 skrev Yuan Fu <casouri@gmail.com>:

> Does it worth the complexity tho? We only need a stack if we want to support 
> this scenario, in which case tree-sitter has a wrong parse tree. Instead of 
> spending the time and resource to go down that deep tree, it’s better to fail 
> early, and let the user decide to either give up on weird files, or try some 
> other approximation.
> 
> It’s too early to tell if being able to go down arbitrarily deep into a deep 
> tree is useful. The only use of traversing the whole tree right now is to 
> generate the imenu indexes, which don’t really need to go down more than 10 
> levels, since most defun nodes we are interested in are either top-level or 
> near top-level.

You may very well be right about that.

> So I’d prefer we keep it simple and have a hard limit for now. If we later 
> find that a stack is favorable we can always add it in.

That sounds good. Maybe the #line snag in the packet-rrc.c example should be 
reported upstream?






reply via email to

[Prev in Thread] Current Thread [Next in Thread]