[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-mode
From: |
Yuan Fu |
Subject: |
bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes) |
Date: |
Mon, 14 Nov 2022 01:25:09 -0800 |
> On Nov 13, 2022, at 11:06 PM, Theodor Thornhill <theo@thornhill.no> wrote:
>
> Yuan Fu <casouri@gmail.com> writes:
>
>>> On Nov 13, 2022, at 3:01 PM, Theodor Thornhill via Bug reports for GNU
>>> Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:
>>>
>>> Theodor Thornhill <theo@thornhill.no> writes:
>>>
>>>> Added a few more finishes.
>>>
>>> Aaand another. Last one for now. I promise…
>>
>> Cool! Some comments:
>>
>> +(defcustom c-ts-mode-font-lock-feature-list
>> + '((comment preprocessor operator constant string literal keyword)
>> + (type definition expression statement)
>> + ())
>> + "Language constructs to font-lock.
>> +
>> +See `treesit-font-lock-feature-list' for description of how to
>> +use this variable. Supported features are as defined in
>> +`c-ts-mode--font-lock-settings'."
>> + :version "29.1"
>> + :type 'list
>> + :safe 'listp
>> + :group 'c)
>> +
>>
>> I think Stefan M’s opinion is to make feature-list private, and let
>> users add/remove features. Right now they can add/remove features with
>> treesit-recompute-feature-list. I guess we can keep them as defvar’s
>> for now, so people as the option to redefine this list should they
>> want to. (One argument against having them as custom options is that,
>> if a user sets it as a custom option, they will miss out on future
>> changes to this variable.)
>>
>>
>> + (setq-local comment-style c-ts-mode-comment-style)
>>
>> Why don’t we let users set comment style themselves? Does cc-mode have a
>> similar variable?
>>
>
> You have a point. Simplified the patch.
>
> Theo
>
> <0001-Fix-some-inconsistencies-in-ts-modes.patch>
Thanks, merged and pushed.
Yuan
- bug#59251: 29.0.50; Fix-some-inconsistencies-in-ts-modes, Theodor Thornhill, 2022/11/13
- Message not available
- bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes), Theodor Thornhill, 2022/11/13
- bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes), Theodor Thornhill, 2022/11/13
- bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes), Yuan Fu, 2022/11/13
- bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes), Eli Zaretskii, 2022/11/14
- bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes), Theodor Thornhill, 2022/11/14
- bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes),
Yuan Fu <=
- bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes), Eli Zaretskii, 2022/11/15
- bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes), Theodor Thornhill, 2022/11/15
bug#59251: 29.0.50; Fix-some-inconsistencies-in-ts-modes, Eli Zaretskii, 2022/11/14