[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58790: Eglot URI parsing bug when using clojure-lsp server
From: |
Eli Zaretskii |
Subject: |
bug#58790: Eglot URI parsing bug when using clojure-lsp server |
Date: |
Fri, 11 Nov 2022 09:29:11 +0200 |
> From: João Távora <joaotavora@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 58790@debbugs.gnu.org,
> felician.nemeth@gmail.com, stefankangas@gmail.com, dgutov@yandex.ru
> Date: Thu, 10 Nov 2022 22:48:20 +0000
>
> Danny Freeman <danny@dfreeman.email> writes:
>
> > In reviewing the comments over and over I've made a modification to
> > the second patch involving the warning message. Instead of using an
> > arbitrary symbol I realized that the function `find-file-name-handler'
> > works when a nil value for the second argument (operation).
>
> I've now pushed the first patch, but I held off the second patch.
>
> I don't see this OPERATION=nil option documented in the docstring of
> find-file-name-handler, so I'm not sure we should rely on it.
>
> I think we should provide OPERATION here, because what we want to check
> is if we, Emacs, can actually visit the file designated by the URI. So
> I think passing something like 'access-file' as the OPERATION argument
> makes more sense. But Eli probably has more knowledge here. Maybe
> passing nil is indeed correct.
I think you are right, but Michael (CC'ed) will know for sure.
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, (continued)
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Eli Zaretskii, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/10
- bug#58790: Eglot URI parsing bug when using clojure-lsp server,
Eli Zaretskii <=
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Michael Albinus, 2022/11/12
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/13
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Michael Albinus, 2022/11/15
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/15
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Michael Albinus, 2022/11/16
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/16
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Michael Albinus, 2022/11/16
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, João Távora, 2022/11/16
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Danny Freeman, 2022/11/16
- bug#58790: Eglot URI parsing bug when using clojure-lsp server, Michael Albinus, 2022/11/22