bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save

[Jim Porter]

On 11/2/2022 1:09 PM, Eli Zaretskii wrote:
> > 'server-delete-client' is called in a bunch of spots, so at minimum, I'd
> > want to be extra-careful that prompting doesn't break one of those
> > cases.
>
> Sorry, I meant server-handle-delete-frame.

Oh, ok. That would be easy then. But since your preference was to just 
leave things as they are, let's not make this change. I can adjust 
things locally without it.

> > > > If starting the server activates a minor mode, then Emacs can use a
> > > > minor-mode keymap for server-mode. [snip]
> > >
> > > I'm fine with doing that, but we must also make sure this mode is
> > > turned on when users invoke server-start interactively.
> >
> > I think that makes sense, and it should be fairly straightforward. I'll
> > work on a patch for this.
>
> Thanks.

Ok, here's a patch for that. It just sets the 'server-mode' variable 
(and 'global-minor-modes' to be polite) inside 'server-start'. It would 
probably be more elegant if we could make 'server-start' just call 
'(server-mode)' (instead of the other way around like it is now), but I 
think it would be hard to do that while staying 100% compatible. Does 
this seem ok?

0001-Enable-disable-server-mode-when-starting-stopping-th.patch
Description: Text document