[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58973: tab navigation in EWW misses textarea and select
From: |
Nicolas Graner |
Subject: |
bug#58973: tab navigation in EWW misses textarea and select |
Date: |
Wed, 02 Nov 2022 22:28:45 +0100 |
In EWW mode, the function shr-next-link moves to the next active area,
which may be a link or an 'input' tag. To make tab navigation in forms
really operational, it should also stop at 'textarea' and 'select' tags.
Below is my suggested patch.
Hope this helps,
Nicolas
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 414de931c4..3799ef96e8 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1596,7 +1596,8 @@ eww-tag-textarea
(list :eww-form eww-form
:value value
:type "textarea"
- :name (dom-attr dom 'name)))))
+ :name (dom-attr dom 'name)))
+ (put-text-property start (1+ start) 'shr-tab-stop t)))
(defun eww-tag-input (dom)
(let ((type (downcase (or (dom-attr dom 'type) "text")))
@@ -1660,7 +1661,8 @@ eww-tag-select
(add-face-text-property start (point) 'eww-form-select)
(put-text-property start (point) 'keymap eww-select-map)
(unless (= start (point))
- (put-text-property start (1+ start) 'help-echo "select field"))
+ (put-text-property start (1+ start) 'help-echo "select field")
+ (put-text-property start (1+ start) 'shr-tab-stop t))
(shr-ensure-paragraph))))
(defun eww-select-display (select)
- bug#58973: tab navigation in EWW misses textarea and select,
Nicolas Graner <=