[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58028: 29.0.50; Ensures no leakage of glyph_matrix
From: |
Manuel Giraud |
Subject: |
bug#58028: 29.0.50; Ensures no leakage of glyph_matrix |
Date: |
Fri, 23 Sep 2022 22:43:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> Cc: 58028@debbugs.gnu.org
>> Date: Fri, 23 Sep 2022 17:59:48 +0200
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> >> Date: Fri, 23 Sep 2022 17:22:07 +0200
>> >>
>> >> Maybe this problem never triggers. It is a « better be safe » kind of
>> >> patch.
>> >
>> > Please add an assertion there, to catch the case that previously was
>> > handled by testing only w->desired_matrix.
>>
>> I do not understand what you mean here.
>
> I mean the assertion that triggers when w->desired_matrix is NULL, but
> w->current_matrix isn't.
Oh I see. I add the following:
--8<---------------cut here---------------start------------->8---
eassert ((w->desired_matrix == NULL) &&
(w->current_matrix != NULL));
--8<---------------cut here---------------end--------------->8---
and test a little bit with emacs -Q and nothing break. So I think
you're right: when w->desired_matrix is NULL, both are.
--
Manuel Giraud
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Manuel Giraud, 2022/09/23
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Eli Zaretskii, 2022/09/23
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Manuel Giraud, 2022/09/23
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Eli Zaretskii, 2022/09/23
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix,
Manuel Giraud <=
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Po Lu, 2022/09/23
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Eli Zaretskii, 2022/09/24
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Manuel Giraud, 2022/09/24
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Lars Ingebrigtsen, 2022/09/24
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Po Lu, 2022/09/24
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Eli Zaretskii, 2022/09/24
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Manuel Giraud, 2022/09/24
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Eli Zaretskii, 2022/09/24
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Manuel Giraud, 2022/09/25
- bug#58028: 29.0.50; Ensures no leakage of glyph_matrix, Eli Zaretskii, 2022/09/25