bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...))


From: Thierry Volpiatto
Subject: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...))
Date: Tue, 23 Aug 2022 10:53:12 +0000

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Thierry Volpiatto <thievol@posteo.net> writes:
>
>> The tests succeed with following patch (avoid setting dired-directory to
>> nil).
>
> Michael noted that there's more fundamental problems in this area,

Indeed there is other problems, like Michael mentionned but also Eli.

I had also problems with `wdired-get-filename` which at the end use
(concat dir file) instead of (expand-file-name file dir).
If filename is absolute we endup with
e.g. "/home/you/tmp//home/you/tmp/foo.txt" instead of
"/home/you/tmp/foo.txt".
Curiously this happen in emacs-28 but not in 29 (why I submitted no
patch for this).

> so perhaps more work is needed later, but your change makes sense
> anyway, I think, so I've now pushed it to Emacs 29.

Great thanks.

-- 
Thierry

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]