bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...))


From: Lars Ingebrigtsen
Subject: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...))
Date: Mon, 22 Aug 2022 12:27:09 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Thierry Volpiatto <thievol@posteo.net> writes:

> +                 (setcdr dired-directory
> +                         ;; Replace in `dired-directory' files that have
> +                         ;; been modified with their new name keeping
> +                         ;; the ones that are unmodified at the same place.
> +                         (cl-loop for f in (cdr dired-directory)
> +                                  collect (or (assoc-default f files-renamed)
> +                                              f)))))

This isn't obviously safe -- I think you're changing the list that
`dired' was originally called with here, which we shouldn't do.  (It may
even be a constant.)

So I think this should be changed to not do that.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]