[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#57066: 29.0.50; Complex emoji overlaps with text
From: |
Protesilaos Stavrou |
Subject: |
bug#57066: 29.0.50; Complex emoji overlaps with text |
Date: |
Thu, 11 Aug 2022 09:35:42 +0300 |
User-agent: |
Notmuch/0.36 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Date: Thu, 11 Aug 2022 15:24:38 +0900
>
> Oops, it breaks non-HarfBuzz builds. Pleae try below instead.
>
> YAMAMOTO Mitsuharu
> mituharu@math.s.chiba-u.ac.jp
>
> diff --git a/src/ftcrfont.c b/src/ftcrfont.c
> index 39ea068556..d5d3e440af 100644
> --- a/src/ftcrfont.c
> +++ b/src/ftcrfont.c
> @@ -568,7 +568,11 @@ ftcrhbfont_begin_hb_font (struct font *font, double
> *position_unit)
>
> ftcrfont_info->ft_size = ft_face->size;
> hb_font_t *hb_font = fthbfont_begin_hb_font (font, position_unit);
> - if (ftcrfont_info->bitmap_position_unit)
> + /* HarfBuzz 5 correctly scales bitmap-only fonts without position
> + unit adjustment.
> + (https://github.com/harfbuzz/harfbuzz/issues/489) */
> + if (!hb_version_atleast (5, 0, 0)
> + && ftcrfont_info->bitmap_position_unit)
> *position_unit = ftcrfont_info->bitmap_position_unit;
>
> return hb_font;
Thank you! I just tried it and it works on my end.
I only tested it with a regular 'make'. Do you want me to use other
build options as well?
--
Protesilaos Stavrou
https://protesilaos.com
- bug#57066: 29.0.50; Complex emoji overlaps with text, (continued)
- bug#57066: 29.0.50; Complex emoji overlaps with text, Eli Zaretskii, 2022/08/09
- bug#57066: 29.0.50; Complex emoji overlaps with text, Protesilaos Stavrou, 2022/08/09
- bug#57066: 29.0.50; Complex emoji overlaps with text, Eli Zaretskii, 2022/08/09
- bug#57066: 29.0.50; Complex emoji overlaps with text, Protesilaos Stavrou, 2022/08/09
- bug#57066: 29.0.50; Complex emoji overlaps with text, Eli Zaretskii, 2022/08/09
- bug#57066: 29.0.50; Complex emoji overlaps with text, Protesilaos Stavrou, 2022/08/09
- bug#57066: 29.0.50; Complex emoji overlaps with text, Eli Zaretskii, 2022/08/10
- bug#57066: 29.0.50; Complex emoji overlaps with text, Protesilaos Stavrou, 2022/08/11
- bug#57066: 29.0.50; Complex emoji overlaps with text, YAMAMOTO Mitsuharu, 2022/08/11
- bug#57066: 29.0.50; Complex emoji overlaps with text, YAMAMOTO Mitsuharu, 2022/08/11
- bug#57066: 29.0.50; Complex emoji overlaps with text,
Protesilaos Stavrou <=
- bug#57066: 29.0.50; Complex emoji overlaps with text, Eli Zaretskii, 2022/08/11
- bug#57066: 29.0.50; Complex emoji overlaps with text, YAMAMOTO Mitsuharu, 2022/08/11
- bug#57066: 29.0.50; Complex emoji overlaps with text, Eli Zaretskii, 2022/08/11
- bug#57066: 29.0.50; Complex emoji overlaps with text, YAMAMOTO Mitsuharu, 2022/08/11
- bug#57066: 29.0.50; Complex emoji overlaps with text, Eli Zaretskii, 2022/08/11
- bug#57066: 29.0.50; Complex emoji overlaps with text, YAMAMOTO Mitsuharu, 2022/08/11
bug#57066: 29.0.50; Complex emoji overlaps with text, Fernando de Morais, 2022/08/09