bug#45607: 27.1; compiled replace-string breaks repeat-complex-command

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Juri Linkov <juri@linkov.net>,  michael_heerdegen@web.de,
>   45607@debbugs.gnu.org,  darkfeline@felesatra.moe
> Date: Tue, 09 Aug 2022 21:15:51 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Bonus points for calling use-region-p just once, not twice.
> 
> I don't really see a convenient way to do that in these cases -- the
> only ones I could think of (adding a new function to return both
> start/end, and then splice the results in into the `interactive' specs
> etc) would lead to obfuscated code.

What about cl-destructuring-bind and its ilk?

> (And it's not like this is performance critical anyway.)

It's IMO inelegant to make the same test twice in a row.