[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY funct
From: |
Augusto Stoffel |
Subject: |
bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks |
Date: |
Mon, 08 Aug 2022 17:16:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
This is a marginally related remark, but I noticed that python-mode sets
(setq-local outline-heading-end-regexp ":[^\n]*\n")
and this doesn't work well with the new-ish type annotation syntax.
Wouldn't it be better to simply remove this setting, reverting back to
the default "\n"? Then folding by outline-minor-mode would behave like
hideshow currently does when it comes to something like
def f(
x: int
) -> int:
pass
On Sun, 7 Aug 2022 at 23:37, kobarity <kobarity@gmail.com> wrote:
> Hi,
>
> Dima Kogan <dima@secretsauce.net> wrote:
>> I do agree that the best thing to do is to use functions instead of pure
>> regexes here. Can we hook that into hs-special-modes-alist instead of
>> doing something specific in python-mode? I'm imagining extending the
>> meaning of the fields in hs-special-modes-alist, where we'd do something
>> different, depending on if some element is a string or not. Maybe that
>> would make it easier to extend the hideshow support for other languages?
>
> If we are to extend hs-special-modes-alist, I think it's better to add
> functions to find/check blocks. Maybe this is the third option
> mentioned in the first mail. For that, I added three functions to
> hs-special-modes-alist:
>
> - hs-find-block-beginning-func
> - hs-find-next-block-func
> - hs-looking-at-block-start-p-func
>
> Attached is a prototype patch to achieve this.
>
> Regards,
- bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks, kobarity, 2022/08/07
- bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks,
Augusto Stoffel <=
- bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks, kobarity, 2022/08/13
- bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks, Lars Ingebrigtsen, 2022/08/17
- bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks, Lars Ingebrigtsen, 2022/08/17
- bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks, kobarity, 2022/08/17
- bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks, Dima Kogan, 2022/08/23
- bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks, Lars Ingebrigtsen, 2022/08/24
- bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks, kobarity, 2022/08/24