[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55768: 26.3; isearch highlighting in dired
From: |
Lars Ingebrigtsen |
Subject: |
bug#55768: 26.3; isearch highlighting in dired |
Date: |
Tue, 28 Jun 2022 19:22:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Juri Linkov <juri@linkov.net> writes:
>>> (invisible-p (point)) has already been tested in the previous line,
>>> but it only tests that
>>> there is a text property, not actual invisibility:
>>> (defun invisible-p (pos)
>>> (get-text-property pos 'invisible))
>>
>> That's not the definition of invisible-p. It's
>>
>> DEFUN ("invisible-p", Finvisible_p, Sinvisible_p, 1, 1, 0,
>> doc: /* Non-nil if text properties at POS cause text there to
>> be currently invisible.
>
> I checked this again, and I see nothing wrong in the current implementation:
>
> (invisible-p (get-text-property (point) 'invisible))
>
> is a valid call, because the arg of ‘invisible-p’ can be the actual value
> of the ‘invisible’ text property.
The claim was that invisible-p:
>>> it only tests that there is a text property, not actual
>>> invisibility
and then there's a definition of invisible-p, which indeed only tests
that. I pointed out that that's not what invisible-p is defined as, or
what it does.
In other words, this:
;; If the following character is currently invisible,
;; skip all characters with that same `invisible' property value.
;; Do that over and over.
(while (and (< (point) end) (invisible-p (point)))
(if (invisible-p (get-text-property (point) 'invisible))
Is fine, but
(eq (invisible-p (point))
(invisible-p (get-text-property (point) 'invisible)))
is always true.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#55768: 26.3; isearch highlighting in dired, Thierry EMERY, 2022/06/02
- bug#55768: 26.3; isearch highlighting in dired, Lars Ingebrigtsen, 2022/06/02
- bug#55768: 26.3; isearch highlighting in dired, Juri Linkov, 2022/06/03
- bug#55768: 26.3; isearch highlighting in dired, Thierry EMERY, 2022/06/03
- bug#55768: 26.3; isearch highlighting in dired, Thierry EMERY, 2022/06/03
- bug#55768: 26.3; isearch highlighting in dired, Lars Ingebrigtsen, 2022/06/04
- bug#55768: 26.3; isearch highlighting in dired, Juri Linkov, 2022/06/28
- bug#55768: 26.3; isearch highlighting in dired,
Lars Ingebrigtsen <=
- bug#55768: 26.3; isearch highlighting in dired, Juri Linkov, 2022/06/28
- bug#55768: 26.3; isearch highlighting in dired, Lars Ingebrigtsen, 2022/06/29
- bug#55768: 26.3; isearch highlighting in dired, Juri Linkov, 2022/06/29
- bug#55768: 26.3; isearch highlighting in dired, Lars Ingebrigtsen, 2022/06/30
- bug#55768: 26.3; isearch highlighting in dired, Thierry EMERY, 2022/06/30
- bug#55768: 26.3; isearch highlighting in dired, Lars Ingebrigtsen, 2022/06/30