[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56155: 29.0.50; Options menu, toggle menu items not updated
From: |
Gerd Möllmann |
Subject: |
bug#56155: 29.0.50; Options menu, toggle menu items not updated |
Date: |
Tue, 28 Jun 2022 14:06:22 +0200 |
> On 2022-06-23,, at 12:15 , Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Gerd Möllmann <gerd.moellmann@gmail.com>
>> Date: Thu, 23 Jun 2022 11:09:16 +0200
>>
>> 1. emacs -Q
>> 2. From the Options menu, select Save Places in Files...
>> 3. The toggle mark on the menu item remains unchanged
>>
>> This seems to work for some menu items, but not for others. Maybe NS
>> specific, I don't know.
>
> I don't see it here, so it's probably NS specific, yes.
I think I have it.
Some toggle menu items lead to a force-mode-line-update, others don't. For
instance, Options -> Hightlight Active Region does lead to a f-m-l-u, Options
-> Enter Debugger on Error doesn't. Consequently, the next redisplay after
selecting the toggle either decides to call set_frame_menubar or not. If it
isn't run, the toggle marks are not updated in the menu.
What I don't know is if this can only be seen on macOS. On macOS, one can
select an option from the menu bar, re-open the Options menu and select
another, wihout Emacs running anything in between the two selections that can
itself set update_mode_lines. If anything else sets update_mode_lines, the ill
effect will not show up. Just clicking in the text area runs a command...
A possible fix that works for me is attached.
Passing t to force-mode-line-update in the patch is be a bit brutal, perhaps.
I didn't want to play games after some brutal debugging.
0001-Ensure-correct-toggle-menu-item-display.patch
Description: Binary data
signature.asc
Description: Message signed with OpenPGP
- bug#56155: 29.0.50; Options menu, toggle menu items not updated, Gerd Möllmann, 2022/06/23
- bug#56155: 29.0.50; Options menu, toggle menu items not updated, Eli Zaretskii, 2022/06/23
- bug#56155: 29.0.50; Options menu, toggle menu items not updated,
Gerd Möllmann <=
- bug#56155: 29.0.50; Options menu, toggle menu items not updated, Stefan Kangas, 2022/06/28
- bug#56155: 29.0.50; Options menu, toggle menu items not updated, Daniel Martín, 2022/06/28
- bug#56155: 29.0.50; Options menu, toggle menu items not updated, Gerd Möllmann, 2022/06/29
- bug#56155: 29.0.50; Options menu, toggle menu items not updated, Po Lu, 2022/06/29
- bug#56155: 29.0.50; Options menu, toggle menu items not updated, Daniel Martín, 2022/06/29
- bug#56155: 29.0.50; Options menu, toggle menu items not updated, Po Lu, 2022/06/29
bug#56155: 29.0.50; Options menu, toggle menu items not updated, Gerd Möllmann, 2022/06/29