bug#46990: 28.0.50; popup menu not navigable via arrow keys on lucid build

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Ah.  Then it's this:
>
> /* For debug, if installation-directory is non-nil this is not an installed
>    Emacs.   In that case we do not grab the keyboard to make it easier to
>    debug. */
> #define GRAB_KEYBOARD  (EQ (Vinstallation_directory, Qnil))
>
> and it's not a bug.

It's always nice when behaviour like this has a logical explanation.  😀

But I'm not sure whether we actually want this.  The commit message is
somewhat vague -- what's the debugging this simplifies?  Is it still
relevant?  I've added Jan to the CCs; perhaps he remembers the reasoning
for the 20 year old change:

diff --git a/lwlib/ChangeLog b/lwlib/ChangeLog
index 28626ddc25..3ead711d79 100644
--- a/lwlib/ChangeLog
+++ b/lwlib/ChangeLog
@@ -1,3 +1,8 @@
+2002-04-28  Jan D.  <jan.h.d@swipnet.se>
+
+       * xlwmenu.c: Do not grab keyboard if installation-directory is
+       non-nil (not installed Emacs).  To simplify debugging.
+


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no