[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56048: [PATCH] bindat (strz): Null terminate fixed-length strings if
From: |
Eli Zaretskii |
Subject: |
bug#56048: [PATCH] bindat (strz): Null terminate fixed-length strings if there is room |
Date: |
Sat, 18 Jun 2022 09:32:51 +0300 |
> Cc: monnier@iro.umontreal.ca
> Date: Fri, 17 Jun 2022 23:02:57 -0400
> From: Richard Hansen <rhansen@rhansen.org>
>
> Attached are new revisions of the patches. The only differences are the
> comments were filled at column 70 instead of 80, and the commit message
> mentions the bug number.
While waiting for Stefan to tell whether he has any comments, a couple
of nits:
> Subject: [PATCH v2 1/2] ; bindat (strz): Move all pack logic to pack function
What is the motivation/rationale for this refactoring?
> +When packing, a null terminator is written after the packed string if
> +the length of the input string is less than @var{len}.
Since "length of a string" is highly ambiguous in Emacs, please always
make a point of saying "@var{len} bytes" explicitly. Byte length is
something rarely seen or used in Emacs, so people must be informed
about that each time.
Thanks.