[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline
From: |
Matthias Meulien |
Subject: |
bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers |
Date: |
Tue, 23 Nov 2021 00:03:23 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Matthias Meulien <orontee@gmail.com> writes:
>> Juri Linkov <juri@linkov.net> writes:
>>
>>> I confirm there is a relation because the commit f0768d3145
>>
>> Oh you're right. Sorry.
>>
>>> However, changing the .+ thing to .* in outline-font-lock-keywords
>>> fixes this problem. So we need to decide whether to try to remove
>>> entire line mathing from diff-hunk-header-re (not sure how easy to
>>> do),
>
> I just skipped last character of `diff-hunk-header-re' (the culprit `$')
> when building `diff-outline-regexp'; Cycling is restored when on hunk
> headers. Looks safe to me since `diff-hunk-header-re' is unchanged.
Ok, it works on hunks with "context information" like
@@ -147,6 +160,61 @@ diff-font-lock-syntax
But it's still broken when there's no "context information" like
@@ -50,6 +50,7 @@
which argues for your second suggestion, changing
`outline-font-lock-keywords'.
--
Matthias
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, (continued)
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/18
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Lars Ingebrigtsen, 2021/11/19
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/19
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Lars Ingebrigtsen, 2021/11/20
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/20
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Lars Ingebrigtsen, 2021/11/21
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Matthias Meulien, 2021/11/21
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/21
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Matthias Meulien, 2021/11/21
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Matthias Meulien, 2021/11/22
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers,
Matthias Meulien <=
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Lars Ingebrigtsen, 2021/11/24
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/24
- bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers, Juri Linkov, 2021/11/21