[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51753: ERC switches to channel buffer on reconnect
From: |
J.P. |
Subject: |
bug#51753: ERC switches to channel buffer on reconnect |
Date: |
Fri, 19 Nov 2021 05:13:58 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) |
Stefan Kangas <stefan@marxist.se> writes:
> On balance, I don't have a strong opinion either way. (I do like
> `erc-reconnect-display' slightly better, because many variables that end
> with `-buffer' have to do with the _name_ of some buffer. But it is
> true that it is also nice to have a name similar to `erc-join-buffer'.)
Screw it. Let's go with `erc-reconnect-display'.
> I just have some minor nits below:
>
>> +(defvar-local erc--server-last-reconnect-count 0
>> + "Snapshot of reconnect count when connection established.")
>
> "when the connection was established", perhaps?
Now reads as ^.
> What is the difference between `buffer' and t? Should they really have
> the same :tag?
No idea to both, unfortunately. But since the option is only used in
that one function (`erc-setup-buffer'), and since we don't claim
like-for-like compatibility with `erc-join-buffer' (which we've already
deviated from anyway by offering a choice of nil) ...
> I suggest we drop one of them.
Agreed. Thanks.
0000-v1-v2.diff
Description: Text Data
0001-Customize-displaying-of-ERC-buffers-on-reconnect.patch
Description: Text Data
- bug#51753: ERC switches to channel buffer on reconnect, Stefan Kangas, 2021/11/10
- bug#51753: ERC switches to channel buffer on reconnect, J.P., 2021/11/10
- Message not available
- bug#51753: ERC switches to channel buffer on reconnect, Lars Ingebrigtsen, 2021/11/10
- bug#51753: ERC switches to channel buffer on reconnect, J.P., 2021/11/11
- bug#51753: ERC switches to channel buffer on reconnect, Lars Ingebrigtsen, 2021/11/11
- bug#51753: ERC switches to channel buffer on reconnect, J.P., 2021/11/19
- bug#51753: ERC switches to channel buffer on reconnect, Stefan Kangas, 2021/11/19
- bug#51753: ERC switches to channel buffer on reconnect,
J.P. <=
- bug#51753: ERC switches to channel buffer on reconnect, J.P., 2021/11/20
- bug#51753: ERC switches to channel buffer on reconnect, Stefan Kangas, 2021/11/20
- bug#51753: ERC switches to channel buffer on reconnect, J.P., 2021/11/21