bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50572: 28.0.50; [PATCH] fix VC to find the responsible backend with


From: Eli Zaretskii
Subject: bug#50572: 28.0.50; [PATCH] fix VC to find the responsible backend with the most specific path.
Date: Fri, 12 Nov 2021 17:20:31 +0200

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 50572@debbugs.gnu.org,  larsi@gnus.org,  andrewjmoreton@gmail.com,
>   dgutov@yandex.ru
> Date: Fri, 12 Nov 2021 16:09:57 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Please don't use "path" for anything that is not PATH-style directory
> > lists.
> 
> Ok but I have hard time figuring out what would be a correct name here
> because (vc-call-backend backend 'responsible-p file) returns a path (or
> nil) if the backend is responsible. Does "path-string" will do?

Either "file-name" or "dir-name", or something along those lines,
should do, I think.  We are talking about variable names, yes?

> > Also, shouldn't the file name(s) be run through expand-file-name, to
> > make sure they are absolute?  Otherwise comparing the length will not
> > DTRT.
> 
> Ok, I'll do this but I'll also need a new name here (in case of a nil
> returned by vc-call-backend): "expanded-path-string" ?

Maybe I'm missing something, but why not test the value for being a
string, and only call expand-file-name if it is?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]