[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50852: [PATCH] Fix search of the look program.
From: |
Stefan Kangas |
Subject: |
bug#50852: [PATCH] Fix search of the look program. |
Date: |
Sat, 30 Oct 2021 09:09:34 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
André A. Gomes <andremegafone@gmail.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Lars Ingebrigtsen <larsi@gnus.org>
>>> Cc: Stefan Kangas <stefan@marxist.se>, andremegafone@gmail.com,
>>> 50852@debbugs.gnu.org
>>> Date: Tue, 28 Sep 2021 08:11:18 +0200
>>>
>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>
>>> > In this case, why not simply have the value as "look" with no leading
>>> > directories? If the program is installed, it will be found when it's
>>> > invoked, and if it isn't installed, the user gets an error message at
>>> > that time.
>>>
>>> That's a good point. And the ispell-look-p variable is itself rather
>>> odd -- why have both ispell-look-command and that variable (with a
>>> non-standard name)?
>>
>> Right. The existence of "look" should IMO be tested as part of
>> ispell-lookup-words, not when the package loads. Then the command
>> could decide whether to use "look" or Grep at that time, and the need
>> for the ispell-look-p variable would disappear.
>
> You're both right. I was actually silly. I can prepare a patch
> following these ideas.
It seems like we are still waiting for this patch. So here's a friendly
reminder to take a look at this when you find some time. :-)
Thanks in advance.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#50852: [PATCH] Fix search of the look program.,
Stefan Kangas <=