[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50160: 28.0.50; Wrong NSToolbarItem identifier
From: |
Alan Third |
Subject: |
bug#50160: 28.0.50; Wrong NSToolbarItem identifier |
Date: |
Sun, 22 Aug 2021 21:09:35 +0100 |
On Sun, Aug 22, 2021 at 11:32:05AM +0900, tsuucat via Bug reports for GNU
Emacs, the Swiss army knife of text editors wrote:
> Emacs version: 28.0.50
> window system: ns
>
> EmacsToolbar now uses [img hash] as NSToolbarItem’s identifier
> (see addDisplayItemWithImage in src/nsmenu.m).
>
> This is not good because this causes conflict.
> For example, “close” icon is used as `kill-this-buffer' by default but
> isearch-tool-bar-map uses “close” icon as `isearch-cancel’.
> addDisplayItemWithImage reuses NSToolbarItem which has same
> identifier so when in isearch “close” icon on toolbar doesn’t work.
Ah, hmm... Perhaps we should append the label text to the hash or
something?
--
Alan Third