[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45550: [PATCH] Factor out new function for readability in chartab.c
From: |
Lars Ingebrigtsen |
Subject: |
bug#45550: [PATCH] Factor out new function for readability in chartab.c |
Date: |
Wed, 21 Jul 2021 14:03:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> > Please make this a macro, not a function. The code you are factoring
>> > out is called in the innermost loops of the display engine, in bidi.c,
>> > so it must be as fast as possible, even in an unoptimized build, where
>> > static functions aren't inlined.
>>
>> Would it be acceptable to use our INLINE macro here instead?
>
> I'd prefer a simple macro. I can never remember the exact semantics
> of INLINE this week.
I've applied Stefan's patch (with the "static inline" tweak, which we
use other places in Emacs, too) because patches bit-rot when they get
too old. If it turns out to be a performance issue, then the inline
function can be rewritten as a macro.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#45550: [PATCH] Factor out new function for readability in chartab.c,
Lars Ingebrigtsen <=