>From 237ad27c3164483cc3c0a9c870db2653456f076c Mon Sep 17 00:00:00 2001 From: Alan Third Date: Sat, 5 Jun 2021 14:38:17 +0100 Subject: [PATCH] Remove pause on fullscreening in NS (bug#48406) * src/nsterm.m (ns_make_frame_visible): (ns_set_parent_frame): ([EmacsView toggleFullScreen:]): Remove calls to removed methods.. ([EmacsView inFullScreenTransition]): ([EmacsView waitFullScreenTransition]): Remove methods. * src/nsterm.h (EmacsView): Remove defintions of removed methods, and the in_fullscreen_transition variable. --- src/nsterm.h | 3 --- src/nsterm.m | 32 ++------------------------------ 2 files changed, 2 insertions(+), 33 deletions(-) diff --git a/src/nsterm.h b/src/nsterm.h index 0596f3f3c1..e7ea907569 100644 --- a/src/nsterm.h +++ b/src/nsterm.h @@ -443,7 +443,6 @@ #define NS_DRAW_TO_BUFFER 1 int maximized_width, maximized_height; NSWindow *nonfs_window; BOOL fs_is_native; - BOOL in_fullscreen_transition; #ifdef NS_DRAW_TO_BUFFER EmacsSurface *surface; #endif @@ -475,8 +474,6 @@ #define NS_DRAW_TO_BUFFER 1 - (void) toggleFullScreen: (id) sender; - (BOOL) fsIsNative; - (BOOL) isFullscreen; -- (BOOL) inFullScreenTransition; -- (void) waitFullScreenTransition; #if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 1070 - (void) updateCollectionBehavior; #endif diff --git a/src/nsterm.m b/src/nsterm.m index f6168243a4..1503f5e2fb 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -1640,8 +1640,6 @@ -(void)remove fullscreen also. So skip handleFS as this will print an error. */ if ([view fsIsNative] && [view isFullscreen]) { - // maybe it is not necessary to wait - [view waitFullScreenTransition]; return; } @@ -2057,11 +2055,7 @@ so some key presses (TAB) are swallowed by the system. */ #if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 1070 // child frame must not be in fullscreen if ([view fsIsNative] && [view isFullscreen]) - { - // in case child is going fullscreen - [view waitFullScreenTransition]; - [view toggleFullScreen:child]; - } + [view toggleFullScreen:child]; NSTRACE ("child setCollectionBehavior:NSWindowCollectionBehaviorFullScreenAuxiliary"); [child setCollectionBehavior:NSWindowCollectionBehaviorFullScreenAuxiliary]; #endif @@ -7963,22 +7957,6 @@ - (void)windowDidExitFullScreen /* provided for direct calls */ [[self window] performZoom:self]; } -- (BOOL)inFullScreenTransition -{ - return in_fullscreen_transition; -} - -- (void)waitFullScreenTransition -{ -#if MAC_OS_X_VERSION_MAX_ALLOWED >= 1070 - while ([self inFullScreenTransition]) - { - NSTRACE ("wait for fullscreen"); - wait_reading_process_output (0, 300000000, 0, 1, Qnil, NULL, 0); - } -#endif -} - - (BOOL)fsIsNative { return fs_is_native; @@ -8058,14 +8036,8 @@ - (void)toggleFullScreen: (id)sender #if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 1070 #if MAC_OS_X_VERSION_MIN_REQUIRED < 1070 if ([[self window] respondsToSelector: @selector(toggleFullScreen:)]) - { -#endif - [[self window] toggleFullScreen:sender]; - // wait for fullscreen animation complete (bug#28496) - [self waitFullScreenTransition]; -#if MAC_OS_X_VERSION_MIN_REQUIRED < 1070 - } #endif + [[self window] toggleFullScreen:sender]; #endif return; } -- 2.29.2