bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#48883: [External] : bug#48883: dired marking bugs


From: Drew Adams
Subject: bug#48883: [External] : bug#48883: dired marking bugs
Date: Mon, 7 Jun 2021 16:16:43 +0000

> > Here's a follow-up related bug: If one marks one of what I've been
> > calling the "not-real" files '.' or ',,' and then perform action 't' to
> > toggle the marks, those elements do not toggle.
> 
> +1.

Hm, the doc string says that `.' and `..' are never
toggled.  That means that this was intentional (why?).

But (luckily) `dired-toggle-marks' is not used
anywhere in the vanilla Emacs Lisp code (except as
for key bindings).

A proper change could perhaps be one of the following:

* Just let it toggle `.' and `..', reversing the
  design (intention) for those.

* Do that only when invoked interactively (so any code
  that invokes it non-interactively isn't affected).

* Add a user option, to control whether it toggles
  `.' and `..'.

(For Dired+ I'll go with the first, at least until
or unless vanilla Emacs decides to do something
else for this.)
___

BTW, the doc string for this is not good.  It speaks
of "other flags (such as `D')".  It should say "other
marks (such as `D')."  `D' is the only mark that we
refer to also as a "flag" - there are no other flags.
___

BTW2: What is the "insdel" referred to in the code
comment?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]