[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' a
From: |
Lars Ingebrigtsen |
Subject: |
bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group |
Date: |
Thu, 03 Jun 2021 09:45:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Since the `:group` was only used for the `defcustom`, I just removed
> this special handling. It doesn't mean it doesn't work any more, but
> now it's just another one of the keyword args that are simply passed
> as-is to `defcustom`.
Ah, I see. But it seems like `define-minor-mode' just discards :group
now. Here's a test case:
(define-minor-mode foo-mode "doc" :group 'mouse)
Since this isn't a global minor mode, we end up in this branch:
((not globalp)
`(progn
:autoload-end
(defvar-local ,mode ,init-value
,(concat (format "Non-nil if %s is enabled.\n" pretty-name)
(internal--format-docstring-line
"Use the command `%s' to change this variable."
mode)))))
and :group (which ends up in `extra-keywords') isn't used. Should this
instead use `defcustom' with :local t? I.e., basically merge with the
global case in that cond?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group, Lars Ingebrigtsen, 2021/06/02
- bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group, Stefan Monnier, 2021/06/02
- bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group,
Lars Ingebrigtsen <=
- bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group, Stefan Monnier, 2021/06/03
- bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group, Lars Ingebrigtsen, 2021/06/04
- bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group, Stefan Monnier, 2021/06/04
- bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group, Lars Ingebrigtsen, 2021/06/06
- bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group, Stefan Monnier, 2021/06/06