[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48037: 28.0.50; add-change-log-entry does not detect name with digit
From: |
Michael Albinus |
Subject: |
bug#48037: 28.0.50; add-change-log-entry does not detect name with digit |
Date: |
Tue, 27 Apr 2021 09:30:19 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
Hi Lars,
>> (defcustom add-log-current-defun-header-regexp
>> - "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]"
>> + "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ \t]*[:=]"
>> "Heuristic regexp used by `add-log-current-defun' for unknown major modes.
>
> This would also catch stuff like
>
> 2:
> stage: slow
>
> which looks like a false positive? So I think there should be some
> alpha in there. Probably.
Yes. However, the existing regexp hits also entries like
-:
stage: slow
Looks also strange. So my proposal won't get worse. Remember,
add-log-current-defun-header-regexp is just a heuristic.
Alternatively, I could just give gitlab-ci.yml a file-local value for
this variable, and let the lions sleep :-)
Best regards, Michael.
- bug#48037: 28.0.50; add-change-log-entry does not detect name with digit, Michael Albinus, 2021/04/26
- bug#48037: 28.0.50; add-change-log-entry does not detect name with digit, Lars Ingebrigtsen, 2021/04/27
- bug#48037: 28.0.50; add-change-log-entry does not detect name with digit,
Michael Albinus <=
- bug#48037: 28.0.50; add-change-log-entry does not detect name with digit, Lars Ingebrigtsen, 2021/04/27
- bug#48037: 28.0.50; add-change-log-entry does not detect name with digit, Michael Albinus, 2021/04/27
- bug#48037: 28.0.50; add-change-log-entry does not detect name with digit, Michael Albinus, 2021/04/27
- bug#48037: 28.0.50; add-change-log-entry does not detect name with digit, Lars Ingebrigtsen, 2021/04/27
- bug#48037: 28.0.50; add-change-log-entry does not detect name with digit, Michael Albinus, 2021/04/28