[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47799: 28.0.50; Default `project-files' implementation doesn't work
From: |
Dmitry Gutov |
Subject: |
bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames |
Date: |
Thu, 22 Apr 2021 03:46:17 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 19.04.2021 23:48, Dmitry Gutov wrote:
And how will we explain anyway that xref-matches-in-files, when called
without the new ROOT argument, doesn't handle remote or quoted file names?
The above is probably the only real blocker I see. Else we would need to
document it to explicitly only take relative file names, I think. Do we
have a precedent in the core library for this?
Other than that, an exploration into an API working with relative files
names sounds good, actually. It could further speed up file listing,
eliminating some concatenations in project--vc-list-files (in the big
project I referred to, that takes it from 1s down to 0.75s).
If you have the time, patches welcome, even rough ones.
So if you can fix this to avoid performance loss in the general case,
that would be a good improvement for now.
In the meantime, I've changed the fix to use the plan explained previously.
Downsides: either all files should be quoted, or none (is that a
reasonable assumption?), and, of course, users which which do have
directories making use of quoting still pay the performance overhead.
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames, Philipp Stephani, 2021/04/15
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames, Dmitry Gutov, 2021/04/15
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames, Philipp Stephani, 2021/04/15
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames, Philipp Stephani, 2021/04/15
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames, Dmitry Gutov, 2021/04/15
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames, Philipp Stephani, 2021/04/18
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames, Dmitry Gutov, 2021/04/18
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames, Philipp Stephani, 2021/04/19
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames, Dmitry Gutov, 2021/04/19
- bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames,
Dmitry Gutov <=