[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47074: Replace XPM icons with Unicode codepoints in customize/widget
From: |
Alan Third |
Subject: |
bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets |
Date: |
Sun, 4 Apr 2021 12:44:00 +0100 |
On Sun, Apr 04, 2021 at 02:37:12PM +0300, Eli Zaretskii wrote:
> > Date: Sat, 3 Apr 2021 23:28:35 +0100
> > From: Alan Third <alan@idiocy.org>
> > Cc: Eli Zaretskii <eliz@gnu.org>, 47074-done@debbugs.gnu.org
> >
> > I've pushed a change up, so hopefully it should all Just Work now.
>
> Alan, this patch calls malloc to allocate face_font_family, but then
> calls xfree to free it. Why didn't you call xmalloc to allocate?
> that's currently the only caller of malloc in the entire image.c.
I originally used malloc, then realised every other call is to xmalloc
and thought I'd fixed them all.
This change appears to have been particularly bad, apologies to
everyone for the mess I've caused.
--
Alan Third
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Stefan Kangas, 2021/04/03
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Eli Zaretskii, 2021/04/04
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Stefan Kangas, 2021/04/04
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Eli Zaretskii, 2021/04/04
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Alan Third, 2021/04/04
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Eli Zaretskii, 2021/04/04
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Eli Zaretskii, 2021/04/04
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Alan Third, 2021/04/04
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Alan Third, 2021/04/04
- bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets, Eli Zaretskii, 2021/04/04