[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project
From: |
Theodor Thornhill |
Subject: |
bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project |
Date: |
Mon, 22 Mar 2021 08:48:47 +0100 |
Hi,
> It's fine, but it would be better for both function's argument to follow
> projectile-add-known-project (meaning, call it 'project-root').
See attached patch.
>
> Regarding report-message, I figured it would just be a separate
> 'message' call in both caller functions. Apparently that might to this
> message appearing more often (due to the requested project not actually
> appearing in project--list?), but I wonder if we shouldn't replace that
> when-let with a presence assertion instead.
Yeah, we could do that. However, the nice thing now is at least that the
behavior is bundled together, so we don't need to remember to
report. Not sure what is best :)
>
> Anyway, the latter is not a big deal; project--remove-from-project-list
> can be changed at any time later.
Sure! Do the manual later, or now?
--
Theo
0001-Add-command-project-remove-known-project.patch
Description: Text Data
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Theodor Thornhill, 2021/03/20
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Dmitry Gutov, 2021/03/20
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Eli Zaretskii, 2021/03/21
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Theodor Thornhill, 2021/03/21
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Dmitry Gutov, 2021/03/21
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Theodor Thornhill, 2021/03/21
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Theodor Thornhill, 2021/03/21
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Dmitry Gutov, 2021/03/21
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project,
Theodor Thornhill <=
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Dmitry Gutov, 2021/03/22
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Theodor Thornhill, 2021/03/22
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Eli Zaretskii, 2021/03/23
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Theodor Thornhill, 2021/03/23
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Eli Zaretskii, 2021/03/23
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Theodor Thornhill, 2021/03/23
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Dmitry Gutov, 2021/03/24
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Basil L. Contovounesios, 2021/03/24
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Dmitry Gutov, 2021/03/24
- bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project, Theodor Thornhill, 2021/03/25