[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46819: 28.0.50; Undesireable warning: Empty let body from the `bench
|
From: |
Lars Ingebrigtsen |
|
Subject: |
bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation |
|
Date: |
Wed, 10 Mar 2021 15:54:30 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Matt Armstrong <matt@rfc20.org> writes:
> How about we fix benchmark's use of `let', and leave the warning in
> place. It does not seem to be generating many other complaints, so it
> may not be particularly annoying after all. I'm currently working with
> `benchmark-run' a bunch and would like the warning gone from that one
> use.
>
> I can make a patch, but a one liner might be quicker for one of you to
> just commit directly. ;-)
Yup; now done.
I think we should keep the byte-compilation warning -- at least for
now. If it leads to false positives all over the place, then perhaps
not, but it's a useful warning, in my opinion.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no