[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46917: 28.0.50; error when unloading feature after loading elp
From: |
Mauro Aranda |
Subject: |
bug#46917: 28.0.50; error when unloading feature after loading elp |
Date: |
Thu, 04 Mar 2021 09:56:06 -0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
tags 46917 patch
quit
Mauro Aranda <maurooaranda@gmail.com> writes:
> Starting from emacs -Q, do:
>
> 1. In the *scratch* buffer, type and evaluate (in any order):
> (require 'autoarg) ; Whatever feature.
> (require 'elp)
>
> 2. Type and evaluate
> (unload-feature 'autoarg)
>
> 3. Emacs signals an error:
> "Unsupported qualifiers in function loadhist-unload-element: (:before :extra
> \"elp\")"
>
Looks like the problem is the order of the qualifiers; the attached
patch should fix it.
Best regards,
Mauro.
>From c05dda94c490a93c360bb5b71ddae7eb1f9cdcb6 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Thu, 4 Mar 2021 09:47:39 -0300
Subject: [PATCH] Fix qualifiers order for loadhist-unload-element in elp.el
* lisp/emacs-lisp/elp.el (loadhist-unload-element): The :extra
qualifier is expected to come before the other qualifiers, so do
that. (Bug#46917)
---
lisp/emacs-lisp/elp.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/elp.el b/lisp/emacs-lisp/elp.el
index cc2927caf4..411ea2af69 100644
--- a/lisp/emacs-lisp/elp.el
+++ b/lisp/emacs-lisp/elp.el
@@ -583,7 +583,7 @@ elp-unload-function
;; continue standard unloading
nil)
-(cl-defmethod loadhist-unload-element :before :extra "elp" ((x (head defun)))
+(cl-defmethod loadhist-unload-element :extra "elp" :before ((x (head defun)))
"Un-instrument before unloading a function."
(elp-restore-function (cdr x)))
--
2.30.0
- bug#46917: 28.0.50; error when unloading feature after loading elp, Mauro Aranda, 2021/03/04
- bug#46917: 28.0.50; error when unloading feature after loading elp,
Mauro Aranda <=
- bug#46917: 28.0.50; error when unloading feature after loading elp, Lars Ingebrigtsen, 2021/03/04
- bug#46917: 28.0.50; error when unloading feature after loading elp, Mauro Aranda, 2021/03/04
- bug#46917: 28.0.50; error when unloading feature after loading elp, Lars Ingebrigtsen, 2021/03/05
- bug#46917: 28.0.50; error when unloading feature after loading elp, Mauro Aranda, 2021/03/05
- bug#46917: 28.0.50; error when unloading feature after loading elp, Stefan Monnier, 2021/03/05
- bug#46917: 28.0.50; error when unloading feature after loading elp, Lars Ingebrigtsen, 2021/03/05
- bug#46917: 28.0.50; error when unloading feature after loading elp, Stefan Monnier, 2021/03/05