[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames.
From: |
Juri Linkov |
Subject: |
bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames. |
Date: |
Sun, 14 Feb 2021 20:50:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
>> Thank you for working on this patch. Please prepare the ChangeLog
>> commit message, so your patch could be pushed to master. Then it would be
>> easier to reason about further changes and base them on the pushed version.
>
> please find the patch including the commit message with ChangeLog attached.
Thanks, now your patch is pushed to master.
While using it, I noticed a new problem.
There is this code in 'tab-switcher':
(let ((tab-bar-new-tab-choice t)
;; Don't enable tab-bar-mode if it's disabled
(tab-bar-show nil))
(tab-bar-new-tab))
Before your patch, I did nothing with the enabled tab-bar,
but now it disables the tab-bar, and doesn't enable it again later,
because tab-bar-show is let-bound to nil.
A good solution would be to add a new choice value to tab-bar-show.
Something like 'do-not-change-tab-bar-lines', but shorter.
Then when let-bound, it should do nothing with the tab-bar-lines.
Also this is related to another problem:
What if the user wants to manually enable the tab bar on one frame only
without enabling tab-bar-mode? Currently it's possible with
(add-hook 'after-make-frame-functions 'toggle-frame-tab-bar)
But tab-bar--update-tab-bar-lines will disable it sooner or later.
Customizing to the same value like 'do-not-change-tab-bar-lines'
will solve this problem as well.
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., (continued)
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Juri Linkov, 2021/02/13
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/13
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Juri Linkov, 2021/02/13
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Juri Linkov, 2021/02/14
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Eli Zaretskii, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Eli Zaretskii, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/16
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/14
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames.,
Juri Linkov <=
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Juri Linkov, 2021/02/14
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., martin rudalics, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Juri Linkov, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., martin rudalics, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Juri Linkov, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/15
- bug#46299: [External] : bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Drew Adams, 2021/02/15
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/16