[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames.
From: |
Juri Linkov |
Subject: |
bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames. |
Date: |
Mon, 08 Feb 2021 20:19:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
Hello Bastian,
> I have tried to clean up my patch a bit more, please see the attached version
> 3.
Thanks, everything looks right, except one thing that you removed
the most important rule:
> - (cond
> - ((eq tab-bar-show t)
> - (tab-bar-mode 1))
This is the core reason of existence of tab-bar-show separate from tab-bar-mode:
when the user creates a new tab, the tab-bar should be activated,
unless the user has customized tab-bar-show to nil.
Actually, a more proper condition should be:
(when tab-bar-show
(tab-bar-mode 1))
and then after that you can use the remaining code:
> + ;; Recalculate tab-bar-lines and update frames
> + (tab-bar--update-tab-bar-lines (selected-frame))
> + (when tab-bar-mode
> + (tab-bar--load-buttons)
> + (tab-bar--define-keys))
In tab-bar-close-other-tabs:
> + ;; Recalculate tab-bar-lines and update frames
> + (tab-bar--update-tab-bar-lines)
It could affect only the selected frame too, i.e.:
(tab-bar--update-tab-bar-lines (selected-frame))
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beischer, 2021/02/04
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Juri Linkov, 2021/02/05
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/05
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/05
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/06
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Juri Linkov, 2021/02/07
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/07
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/08
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames.,
Juri Linkov <=
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/08
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., martin rudalics, 2021/02/09
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/09
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., martin rudalics, 2021/02/09
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/09
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., martin rudalics, 2021/02/09
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/09
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., martin rudalics, 2021/02/09
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Juri Linkov, 2021/02/09
- bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames., Bastian Beranek, 2021/02/09